Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected download location in the README of libconfig-v1.7.3 #190

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

hex3262
Copy link
Contributor

@hex3262 hex3262 commented Jan 21, 2025

The download location led to the HTML release page and not to the archive, corrected.

Copy link
Contributor

@OliverFendt OliverFendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hex3262 thank you very much for the contribution. I downloaded the "tagged sources" up to now I did not download the packages from the "releases". So the correct link is https://github.com/hyperrealm/libconfig/archive/refs/tags/v1.7.3.tar.gz
The point is that some "release versions" differ from the "tagged" versions of the same tag. I checked the libconfig release version as far as I can see they are equal. Nevertheless we need to provide the exact link where the sources were downloaded from, i.e. the link given above.
As a next step we can think about whether we want to provide also the "release link" after we have proofed that both point to the same source package.
For now I ask you to correct the download link that it points to the tagged version (the link given above).

@hex3262 hex3262 requested a review from OliverFendt February 5, 2025 16:11
Copy link
Contributor

@OliverFendt OliverFendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hex3262 thank you very much for the correction

@OliverFendt OliverFendt merged commit 922733f into Open-Source-Compliance:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants